apache / apache/libcloud

Proposal: Sharable upload links for S3 and Azure Blobs

オープン
#1,458 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る
api: storage
主要言語
Python
スター
2.1k
フォーク
931
平均マージ
1日 2時間
マージ済み PR(30日)
4

説明

## Proposal -
This is a follow-up to @rvolykh's proposal in #1403 -

> AWS S3 has the support of Presigned Object URL and Azure Blob Storage has the support of Shared access signature. [...]
> My proposal is to extend get_object_cdn_url with additional parameter (mode=["read", "write"]) and implement support for AWS S3 and Azure Blob Storage.

The **"read"** version of this functionality was implemented AWS S3 in #1453 and for Azure Blobs in #1408 via the `StorageDriver.get_object_cdn_url` method.

Here I'm proposing the **"write"** version - a method that generates a pre-authorized, time-limited URL that allows _upload_ of a given object. I _think_ the implementation would be trivial - just change
- `"GET"` to `"PUT"` [here](https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/s3.py#L1168)
- `"r"` to `"w"` [here](https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/azure_blobs.py#L530).

I'd be happy to contribute a PR for this. But I'm not sure where the new function would go, though. Would it make sense to add a new abstract method to `StorageDriver`, e.g., `StorageDriver.get_presigned_upload_url(container: str, object_name: str) -> str`?

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start with StorageDriver.get_object_cdn_url and the referenced implementations in libcloud/storage/drivers/s3.py around line 1168 and libcloud/storage/drivers/azure_blobs.py around line 530. Review how the existing read URLs are exposed, then determine the appropriate shared API for write URLs. Done means upload URLs work for both AWS S3 and Azure Blob Storage with a consistent public interface.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
aws, azure, python
領域
cloud
issue の種類
機能追加
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。