apache / apache/libcloud

Proposal: Sharable upload links for S3 and Azure Blobs

Ouverte
#1,458 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
api: storage
Langage dominant
Python
Étoiles
2.1k
Forks
931
Merge moyen
1 j 2 h
PR mergées (30 j)
4

Description

## Proposal -
This is a follow-up to @rvolykh's proposal in #1403 -

> AWS S3 has the support of Presigned Object URL and Azure Blob Storage has the support of Shared access signature. [...]
> My proposal is to extend get_object_cdn_url with additional parameter (mode=["read", "write"]) and implement support for AWS S3 and Azure Blob Storage.

The **"read"** version of this functionality was implemented AWS S3 in #1453 and for Azure Blobs in #1408 via the `StorageDriver.get_object_cdn_url` method.

Here I'm proposing the **"write"** version - a method that generates a pre-authorized, time-limited URL that allows _upload_ of a given object. I _think_ the implementation would be trivial - just change
- `"GET"` to `"PUT"` [here](https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/s3.py#L1168)
- `"r"` to `"w"` [here](https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/azure_blobs.py#L530).

I'd be happy to contribute a PR for this. But I'm not sure where the new function would go, though. Would it make sense to add a new abstract method to `StorageDriver`, e.g., `StorageDriver.get_presigned_upload_url(container: str, object_name: str) -> str`?

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start with StorageDriver.get_object_cdn_url and the referenced implementations in libcloud/storage/drivers/s3.py around line 1168 and libcloud/storage/drivers/azure_blobs.py around line 530. Review how the existing read URLs are exposed, then determine the appropriate shared API for write URLs. Done means upload URLs work for both AWS S3 and Azure Blob Storage with a consistent public interface.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
aws, azure, python
Domaine
cloud
Type d'issue
Fonctionnalité
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.