apache / apache/libcloud

Proposal: Sharable upload links for S3 and Azure Blobs

未关闭
#1,458 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
api: storage
主要语言
Python
星标
2.1k
派生
931
平均合并
1 天 2 小时
30 天内合并 PR
4

描述

## Proposal -
This is a follow-up to @rvolykh's proposal in #1403 -

> AWS S3 has the support of Presigned Object URL and Azure Blob Storage has the support of Shared access signature. [...]
> My proposal is to extend get_object_cdn_url with additional parameter (mode=["read", "write"]) and implement support for AWS S3 and Azure Blob Storage.

The **"read"** version of this functionality was implemented AWS S3 in #1453 and for Azure Blobs in #1408 via the `StorageDriver.get_object_cdn_url` method.

Here I'm proposing the **"write"** version - a method that generates a pre-authorized, time-limited URL that allows _upload_ of a given object. I _think_ the implementation would be trivial - just change
- `"GET"` to `"PUT"` [here](https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/s3.py#L1168)
- `"r"` to `"w"` [here](https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/azure_blobs.py#L530).

I'd be happy to contribute a PR for this. But I'm not sure where the new function would go, though. Would it make sense to add a new abstract method to `StorageDriver`, e.g., `StorageDriver.get_presigned_upload_url(container: str, object_name: str) -> str`?

贡献指南

打开贡献指南

调研方向

Start with StorageDriver.get_object_cdn_url and the referenced implementations in libcloud/storage/drivers/s3.py around line 1168 and libcloud/storage/drivers/azure_blobs.py around line 530. Review how the existing read URLs are exposed, then determine the appropriate shared API for write URLs. Done means upload URLs work for both AWS S3 and Azure Blob Storage with a consistent public interface.

由索引模型根据 Issue 内容生成。

评估

技术栈
aws, azure, python
领域
cloud
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。