FileIO parameter should be arrow::fs::FileSystem ?
Open
- Dominant language
- C++
- Stars
- 221
- Forks
- 124
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 21
Description
The ManifestWriter/ManifestListWriter API uses the` std::shared_ptr` parameter for the IO interface,
which actually should be an internal `arrow::ArrowFileSystemFileIO` (not publicly accessible).
It appears that only the `fs()` is actually utilized.
```c++
auto io = internal::checked_pointer_cast(options.io);
ICEBERG_ARROW_ASSIGN_OR_RETURN(auto output, io->fs()->OpenOutputStream(options.path));
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.