ankidroid / ankidroid/Anki-Android

Remove `DeckSpinnerSelection` and recode `DeckSelectionDialog`

Aperta
#18,875 5 commenti 0 reazioni 1 assegnatario Rivendicata da @lukstbit Vedi su GitHub
cleanup Keep Open
Lingua principale
Kotlin
Stelle
11.8k
Fork
2.9k
Merge medio
2g 3h
PR unite (30g)
171

Descrizione

It's been a mess for years. We can do much better, especially now we're in Kotlin

This class originally existed because we had a spinner to select decks

This became `DeckSelectionDialog`, but the spinner remained.

This could be a spinner embedded in the App Bar, or a View in Note Editor.

Even if we keep a spinner control for the UI, the implementation is currently far too complex to justify it.

`CreateDeckDialog` was then added into `DeckSelectionDialog`, so in some instances, the calling activity needs to handle a newly created deck from this dialog.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.