ankidroid / ankidroid/Anki-Android

Remove `DeckSpinnerSelection` and recode `DeckSelectionDialog`

Offen
#18,875 5 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @lukstbit Auf GitHub ansehen
cleanup Keep Open
Vorherrschende Sprache
Kotlin
Sterne
11.8k
Forks
2.9k
Ø Merge
2 T. 3 Std.
Gemergte PRs (30 T.)
171

Beschreibung

It's been a mess for years. We can do much better, especially now we're in Kotlin

This class originally existed because we had a spinner to select decks

This became `DeckSelectionDialog`, but the spinner remained.

This could be a spinner embedded in the App Bar, or a View in Note Editor.

Even if we keep a spinner control for the UI, the implementation is currently far too complex to justify it.

`CreateDeckDialog` was then added into `DeckSelectionDialog`, so in some instances, the calling activity needs to handle a newly created deck from this dialog.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.