ankidroid / ankidroid/Anki-Android

Remove `DeckSpinnerSelection` and recode `DeckSelectionDialog`

Abierto
#18,875 5 comentarios 0 reacciones 1 asignado Reclamado por @lukstbit Ver en GitHub
cleanup Keep Open
Lenguaje dominante
Kotlin
Estrellas
11.8k
Forks
2.9k
Merge medio
2 d 3 h
PR fusionados (30 d)
171

Descripción

It's been a mess for years. We can do much better, especially now we're in Kotlin

This class originally existed because we had a spinner to select decks

This became `DeckSelectionDialog`, but the spinner remained.

This could be a spinner embedded in the App Bar, or a View in Note Editor.

Even if we keep a spinner control for the UI, the implementation is currently far too complex to justify it.

`CreateDeckDialog` was then added into `DeckSelectionDialog`, so in some instances, the calling activity needs to handle a newly created deck from this dialog.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.