ankidroid / ankidroid/Anki-Android

Remove `DeckSpinnerSelection` and recode `DeckSelectionDialog`

Ouverte
#18,875 5 commentaires 0 réactions 1 personne assignée Réclamée par @lukstbit Voir sur GitHub
cleanup Keep Open
Langage dominant
Kotlin
Étoiles
11.8k
Forks
2.9k
Merge moyen
2 j 3 h
PR mergées (30 j)
171

Description

It's been a mess for years. We can do much better, especially now we're in Kotlin

This class originally existed because we had a spinner to select decks

This became `DeckSelectionDialog`, but the spinner remained.

This could be a spinner embedded in the App Bar, or a View in Note Editor.

Even if we keep a spinner control for the UI, the implementation is currently far too complex to justify it.

`CreateDeckDialog` was then added into `DeckSelectionDialog`, so in some instances, the calling activity needs to handle a newly created deck from this dialog.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.