anitab-org / anitab-org/mentorship-backend

Require mentor's approval for task completion

Đang mở
#278 7 bình luận 1 reaction 1 người được giao Được @RiddhiAthreya nhận Xem trên GitHub
Category: Coding Type: Enhancement
Ngôn ngữ chính
Python
Star
200
Fork
449
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

**Is your feature request related to a problem? Please describe.**
This was first raised by [asawesome07](https://github.com/asawesome07) in [this PR](https://github.com/systers/mentorship-android/issues/335).
What he suggests is adding a new feature: in a specific mentorship relatio, the user can't mark the task as completed himself - he needs the mettor's approval.

**Describe the solution you'd like**
I think the best solution is to add a new property to relation data model. This property would indentify whether mentee can mark tasks as completed by himself or needs a mentor to approve task completion.

This property could be named [for example] `requires_approval: [boolean]`

It would default to `false` when the relation is created. After that, only mentor would be able to change it.

**Describe alternatives you've considered**
I think the above is the simplest solution, but there might be a better one I'm not aware of.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.