anitab-org / anitab-org/mentorship-backend

Require mentor's approval for task completion

Open
#278 7 comments 1 reaction 1 assignee Claimed by @RiddhiAthreya View on GitHub
Category: Coding Type: Enhancement
Dominant language
Python
Stars
200
Forks
449
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
This was first raised by [asawesome07](https://github.com/asawesome07) in [this PR](https://github.com/systers/mentorship-android/issues/335).
What he suggests is adding a new feature: in a specific mentorship relatio, the user can't mark the task as completed himself - he needs the mettor's approval.

**Describe the solution you'd like**
I think the best solution is to add a new property to relation data model. This property would indentify whether mentee can mark tasks as completed by himself or needs a mentor to approve task completion.

This property could be named [for example] `requires_approval: [boolean]`

It would default to `false` when the relation is created. After that, only mentor would be able to change it.

**Describe alternatives you've considered**
I think the above is the simplest solution, but there might be a better one I'm not aware of.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.