anitab-org / anitab-org/mentorship-backend

Require mentor's approval for task completion

Abierto
#278 7 comentarios 1 reacción 1 asignado Reclamado por @RiddhiAthreya Ver en GitHub
Category: Coding Type: Enhancement
Lenguaje dominante
Python
Estrellas
200
Forks
449
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Is your feature request related to a problem? Please describe.**
This was first raised by [asawesome07](https://github.com/asawesome07) in [this PR](https://github.com/systers/mentorship-android/issues/335).
What he suggests is adding a new feature: in a specific mentorship relatio, the user can't mark the task as completed himself - he needs the mettor's approval.

**Describe the solution you'd like**
I think the best solution is to add a new property to relation data model. This property would indentify whether mentee can mark tasks as completed by himself or needs a mentor to approve task completion.

This property could be named [for example] `requires_approval: [boolean]`

It would default to `false` when the relation is created. After that, only mentor would be able to change it.

**Describe alternatives you've considered**
I think the above is the simplest solution, but there might be a better one I'm not aware of.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.