Typing is lost when a converter is specified in versions > 6.0.3
- Dominant language
- TypeScript
- Stars
- 7.8k
- Forks
- 2.2k
- Avg merge
- 22h 28m
- Merged PRs (30d)
- 6
Description
Hi,
When i upgrade to the latest version WithConverter returns a plain Javascript Object instead of the requested class.
This seems to be a bug in rxfire. Se this issue as well: https://github.com/FirebaseExtended/rxfire/issues/93
### Version info
**Angular:** ^18.2.0
**Firebase:** ^10.12.0
**AngularFire:** ^18.0.1
### How to reproduce these conditions
**Steps to set up and reproduce**
Create a class, run a query with a converter, debug the output of the query.
### Expected behavior
A query with the withConverter operator should return the class not a plain javascript object.
### Actual behavior
It returns a plain javascript object.
Contributor guide
Research direction
Reproduce the query with a converter using Angular 18.2.0, Firebase 10.12.0, and AngularFire 18.0.1, then inspect why withConverter returns a plain JavaScript object instead of the requested class. Compare the behavior with the related rxfire issue 93. Done means the query result preserves the converted class.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, firebase, typescript
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100