andywer / andywer/threads.js

Docs/Enhancement: OOB Example doesn't work. Master.js and Auth.js

未關閉
#375 0 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
TypeScript
星號
3.5k
分支
173
PR 合併指標
30 天內沒有已合併 PR

描述

It seems like the example code assumes a user is using ES/CJS modules...most NPM packages use the standards const ... = require(package) syntax and dont assume someone is working in the module context

Found it kinda confusing that "master.js" is not using require and auth.js isn't referred to as ".mjs". Is this intentional? because this the quick start doesn't work OOB.

Quick start should be
1. npm install threads
2. add {type: module} to your package.json since master and auth assume their app embeds it as a ES module and not a typical nodejs package

Thoughts?

Great work btw!

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。