Docs/Enhancement: OOB Example doesn't work. Master.js and Auth.js
Ouverte
- Langage dominant
- TypeScript
- Étoiles
- 3.5k
- Forks
- 173
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
It seems like the example code assumes a user is using ES/CJS modules...most NPM packages use the standards const ... = require(package) syntax and dont assume someone is working in the module context
Found it kinda confusing that "master.js" is not using require and auth.js isn't referred to as ".mjs". Is this intentional? because this the quick start doesn't work OOB.
Quick start should be
1. npm install threads
2. add {type: module} to your package.json since master and auth assume their app embeds it as a ES module and not a typical nodejs package
Thoughts?
Great work btw!
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.