andywer / andywer/threads.js

Docs/Enhancement: OOB Example doesn't work. Master.js and Auth.js

未关闭
#375 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
3.5k
派生
173
PR 合并指标
30 天内没有已合并 PR

描述

It seems like the example code assumes a user is using ES/CJS modules...most NPM packages use the standards const ... = require(package) syntax and dont assume someone is working in the module context

Found it kinda confusing that "master.js" is not using require and auth.js isn't referred to as ".mjs". Is this intentional? because this the quick start doesn't work OOB.

Quick start should be
1. npm install threads
2. add {type: module} to your package.json since master and auth assume their app embeds it as a ES module and not a typical nodejs package

Thoughts?

Great work btw!

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。