andywer / andywer/threads.js

Docs/Enhancement: OOB Example doesn't work. Master.js and Auth.js

Aperta
#375 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
3.5k
Fork
173
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

It seems like the example code assumes a user is using ES/CJS modules...most NPM packages use the standards const ... = require(package) syntax and dont assume someone is working in the module context

Found it kinda confusing that "master.js" is not using require and auth.js isn't referred to as ".mjs". Is this intentional? because this the quick start doesn't work OOB.

Quick start should be
1. npm install threads
2. add {type: module} to your package.json since master and auth assume their app embeds it as a ES module and not a typical nodejs package

Thoughts?

Great work btw!

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.