android10 / android10/Android-CleanArchitecture-Kotlin

Why MovieDetailsAnimator is not injected as a @Singleton?

未關閉
#83 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Kotlin
星號
4.8k
分支
929
PR 合併指標
30 天內沒有已合併 PR

描述

First of all, thank you so much for this awesome repository.

**I have a question about dependency injection:**
You inject MovieDetailsAnimator
`@Inject lateinit var movieDetailsAnimator: MovieDetailsAnimator`
at line 60, MovieDetailsFragment.kt.

And MovieDetailsAnimator is constructed through
`class MovieDetailsAnimator @Inject constructor()`

Wouldn't it be better if MovieDetailsAnimator was constructed with @Singleton annotation? Something like:
`@Singleton class MovieDetailsAnimator @Inject constructor()`
It seems like there is no point on getting a new instance of MovieDetailsAnimator for every fragment.

Thank you! 👍

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。