android10 / android10/Android-CleanArchitecture-Kotlin

Why MovieDetailsAnimator is not injected as a @Singleton?

Aperta
#83 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Kotlin
Stelle
4.8k
Fork
929
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

First of all, thank you so much for this awesome repository.

**I have a question about dependency injection:**
You inject MovieDetailsAnimator
`@Inject lateinit var movieDetailsAnimator: MovieDetailsAnimator`
at line 60, MovieDetailsFragment.kt.

And MovieDetailsAnimator is constructed through
`class MovieDetailsAnimator @Inject constructor()`

Wouldn't it be better if MovieDetailsAnimator was constructed with @Singleton annotation? Something like:
`@Singleton class MovieDetailsAnimator @Inject constructor()`
It seems like there is no point on getting a new instance of MovieDetailsAnimator for every fragment.

Thank you! 👍

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.