android10 / android10/Android-CleanArchitecture-Kotlin
Why MovieDetailsAnimator is not injected as a @Singleton?
- Vorherrschende Sprache
- Kotlin
- Sterne
- 4.8k
- Forks
- 929
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
First of all, thank you so much for this awesome repository.
**I have a question about dependency injection:**
You inject MovieDetailsAnimator
`@Inject lateinit var movieDetailsAnimator: MovieDetailsAnimator`
at line 60, MovieDetailsFragment.kt.
And MovieDetailsAnimator is constructed through
`class MovieDetailsAnimator @Inject constructor()`
Wouldn't it be better if MovieDetailsAnimator was constructed with @Singleton annotation? Something like:
`@Singleton class MovieDetailsAnimator @Inject constructor()`
It seems like there is no point on getting a new instance of MovieDetailsAnimator for every fragment.
Thank you! 👍
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Bewertung
Dieses Issue wurde noch nicht bewertet.