android10 / android10/Android-CleanArchitecture-Kotlin
Why MovieDetailsAnimator is not injected as a @Singleton?
- Langage dominant
- Kotlin
- Étoiles
- 4.8k
- Forks
- 929
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
First of all, thank you so much for this awesome repository.
**I have a question about dependency injection:**
You inject MovieDetailsAnimator
`@Inject lateinit var movieDetailsAnimator: MovieDetailsAnimator`
at line 60, MovieDetailsFragment.kt.
And MovieDetailsAnimator is constructed through
`class MovieDetailsAnimator @Inject constructor()`
Wouldn't it be better if MovieDetailsAnimator was constructed with @Singleton annotation? Something like:
`@Singleton class MovieDetailsAnimator @Inject constructor()`
It seems like there is no point on getting a new instance of MovieDetailsAnimator for every fragment.
Thank you! 👍
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.