android10 / android10/Android-CleanArchitecture-Kotlin

Why MovieDetailsAnimator is not injected as a @Singleton?

未关闭
#83 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Kotlin
星标
4.8k
派生
929
PR 合并指标
30 天内没有已合并 PR

描述

First of all, thank you so much for this awesome repository.

**I have a question about dependency injection:**
You inject MovieDetailsAnimator
`@Inject lateinit var movieDetailsAnimator: MovieDetailsAnimator`
at line 60, MovieDetailsFragment.kt.

And MovieDetailsAnimator is constructed through
`class MovieDetailsAnimator @Inject constructor()`

Wouldn't it be better if MovieDetailsAnimator was constructed with @Singleton annotation? Something like:
`@Singleton class MovieDetailsAnimator @Inject constructor()`
It seems like there is no point on getting a new instance of MovieDetailsAnimator for every fragment.

Thank you! 👍

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。