alloy-rs / alloy-rs/core

[Refactor] Redesign APIs to prevent users from wanting to keep JSON abi data

未关闭
#670 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Rust
星标
967
派生
274
平均合并
1 天 21 小时
30 天内合并 PR
15

描述

JSON ABIs are an anti-pattern because they have fallible resolution steps before every encoding

we would prefer the user resolve an entire `DynInterface` at once, and then reference parts of it

hmmm. I think that if users are keeping the json representation in memory and passing it around, that's generally an anti-pattern, right? I see these traits as convenience functions for one-off things and to patch functionality holes, not as core API. `Dyn____` is our in-memory representation of ABI information, and greedily resolving a `JsonAbi` into a `DynAbi` is the longterm officially-recommended path

_Originally posted by @prestwich in https://github.com/alloy-rs/core/pull/632#discussion_r1627614889_

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。