alloy-rs / alloy-rs/core

[Refactor] Redesign APIs to prevent users from wanting to keep JSON abi data

Open
#670 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
967
Forks
274
Avg merge
1d 21h
Merged PRs (30d)
15

Description

JSON ABIs are an anti-pattern because they have fallible resolution steps before every encoding

we would prefer the user resolve an entire `DynInterface` at once, and then reference parts of it

hmmm. I think that if users are keeping the json representation in memory and passing it around, that's generally an anti-pattern, right? I see these traits as convenience functions for one-off things and to patch functionality holes, not as core API. `Dyn____` is our in-memory representation of ABI information, and greedily resolving a `JsonAbi` into a `DynAbi` is the longterm officially-recommended path

_Originally posted by @prestwich in https://github.com/alloy-rs/core/pull/632#discussion_r1627614889_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.