alloy-rs / alloy-rs/core

[Refactor] Redesign APIs to prevent users from wanting to keep JSON abi data

Offen
#670 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
967
Forks
274
Ø Merge
1 T. 21 Std.
Gemergte PRs (30 T.)
15

Beschreibung

JSON ABIs are an anti-pattern because they have fallible resolution steps before every encoding

we would prefer the user resolve an entire `DynInterface` at once, and then reference parts of it

hmmm. I think that if users are keeping the json representation in memory and passing it around, that's generally an anti-pattern, right? I see these traits as convenience functions for one-off things and to patch functionality holes, not as core API. `Dyn____` is our in-memory representation of ABI information, and greedily resolving a `JsonAbi` into a `DynAbi` is the longterm officially-recommended path

_Originally posted by @prestwich in https://github.com/alloy-rs/core/pull/632#discussion_r1627614889_

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.