alloy-rs / alloy-rs/core

[Refactor] Redesign APIs to prevent users from wanting to keep JSON abi data

Ouverte
#670 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Rust
Étoiles
967
Forks
274
Merge moyen
1 j 21 h
PR mergées (30 j)
15

Description

JSON ABIs are an anti-pattern because they have fallible resolution steps before every encoding

we would prefer the user resolve an entire `DynInterface` at once, and then reference parts of it

hmmm. I think that if users are keeping the json representation in memory and passing it around, that's generally an anti-pattern, right? I see these traits as convenience functions for one-off things and to patch functionality holes, not as core API. `Dyn____` is our in-memory representation of ABI information, and greedily resolving a `JsonAbi` into a `DynAbi` is the longterm officially-recommended path

_Originally posted by @prestwich in https://github.com/alloy-rs/core/pull/632#discussion_r1627614889_

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.