agent-substrate / agent-substrate/substrate

First resume from golden snapshot always restores FULL scope regardless of onSuspend/onResume settings

Aberta
#1,567 1 comentário 0 reações 0 responsáveis Ver no GitHub
area/api area/api-machinery kind/design
Linguagem predominante
Go
Estrelas
1.8k
Forks
316
Merge médio
2d 43min
PRs com merge (30d)
287

Descrição

After the actor has its own snapshot (ignore upgrades for now), the snapshot that the Actors are restoring from has its scope equal to `actorTemplate.onSuspend.Scope` (or the onPause equivalent), but the first resume using golden snapshot is an exception.

Because the golden snapshot is always "FULL" scoped, regardless of the value of onSuspend and onResume settings, the first resume using golden snapshot always restores the full snapshot. Is this ok?

This means, for an actor whose template has `onSuspend: Data` and `onResume.fromData: data_only`, the first resume still restores the full golden snapshot.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.