agent-substrate / agent-substrate/substrate

First resume from golden snapshot always restores FULL scope regardless of onSuspend/onResume settings

Aperta
#1,567 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
area/api area/api-machinery kind/design
Lingua principale
Go
Stelle
1.8k
Fork
316
Merge medio
2g 43m
PR unite (30g)
287

Descrizione

After the actor has its own snapshot (ignore upgrades for now), the snapshot that the Actors are restoring from has its scope equal to `actorTemplate.onSuspend.Scope` (or the onPause equivalent), but the first resume using golden snapshot is an exception.

Because the golden snapshot is always "FULL" scoped, regardless of the value of onSuspend and onResume settings, the first resume using golden snapshot always restores the full snapshot. Is this ok?

This means, for an actor whose template has `onSuspend: Data` and `onResume.fromData: data_only`, the first resume still restores the full golden snapshot.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.