agent-substrate / agent-substrate/substrate

First resume from golden snapshot always restores FULL scope regardless of onSuspend/onResume settings

Open
#1,567 1 comment 0 reactions 0 assignees View on GitHub
area/api area/api-machinery kind/design
Dominant language
Go
Stars
1.8k
Forks
316
Avg merge
2d 43m
Merged PRs (30d)
287

Description

After the actor has its own snapshot (ignore upgrades for now), the snapshot that the Actors are restoring from has its scope equal to `actorTemplate.onSuspend.Scope` (or the onPause equivalent), but the first resume using golden snapshot is an exception.

Because the golden snapshot is always "FULL" scoped, regardless of the value of onSuspend and onResume settings, the first resume using golden snapshot always restores the full snapshot. Is this ok?

This means, for an actor whose template has `onSuspend: Data` and `onResume.fromData: data_only`, the first resume still restores the full golden snapshot.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.