agent-substrate / agent-substrate/substrate

First resume from golden snapshot always restores FULL scope regardless of onSuspend/onResume settings

Ouverte
#1,567 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
area/api area/api-machinery kind/design
Langage dominant
Go
Étoiles
1.8k
Forks
316
Merge moyen
2 j 43 min
PR mergées (30 j)
287

Description

After the actor has its own snapshot (ignore upgrades for now), the snapshot that the Actors are restoring from has its scope equal to `actorTemplate.onSuspend.Scope` (or the onPause equivalent), but the first resume using golden snapshot is an exception.

Because the golden snapshot is always "FULL" scoped, regardless of the value of onSuspend and onResume settings, the first resume using golden snapshot always restores the full snapshot. Is this ok?

This means, for an actor whose template has `onSuspend: Data` and `onResume.fromData: data_only`, the first resume still restores the full golden snapshot.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.