adopted-ember-addons / adopted-ember-addons/ember-changeset-validations

`buildMessage` function is backwards incompatible

未关闭
#141 2 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
215
派生
98
PR 合并指标
30 天内没有已合并 PR

描述

## Version

Latest Master starting at #126

## Test Case

## Steps to reproduce

## Expected Behavior

From the Docs and existing behavior the `buildMessage` function should have a signature like this:
`buildMessage(key, type, value, context = {})`.

## Actual Behavior

On [this line](https://github.com/DockYard/ember-changeset-validations/blob/master/addon/utils/validation-errors.js#L17) the signature made a backwards incompatible change and now looks like this: `buildMessage(key, result)`.

Is the next release intended to bump the major version? If not, any apps relying on `buildMessage` will be broken.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。