adopted-ember-addons / adopted-ember-addons/ember-changeset-validations

`buildMessage` function is backwards incompatible

Aperta
#141 2 commenti 2 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
215
Fork
98
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

## Version

Latest Master starting at #126

## Test Case

## Steps to reproduce

## Expected Behavior

From the Docs and existing behavior the `buildMessage` function should have a signature like this:
`buildMessage(key, type, value, context = {})`.

## Actual Behavior

On [this line](https://github.com/DockYard/ember-changeset-validations/blob/master/addon/utils/validation-errors.js#L17) the signature made a backwards incompatible change and now looks like this: `buildMessage(key, result)`.

Is the next release intended to bump the major version? If not, any apps relying on `buildMessage` will be broken.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.