adopted-ember-addons / adopted-ember-addons/ember-changeset-validations

`buildMessage` function is backwards incompatible

Open
#141 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
215
Forks
98
PR merge metrics
No merged PRs in 30d

Description

## Version

Latest Master starting at #126

## Test Case

## Steps to reproduce

## Expected Behavior

From the Docs and existing behavior the `buildMessage` function should have a signature like this:
`buildMessage(key, type, value, context = {})`.

## Actual Behavior

On [this line](https://github.com/DockYard/ember-changeset-validations/blob/master/addon/utils/validation-errors.js#L17) the signature made a backwards incompatible change and now looks like this: `buildMessage(key, result)`.

Is the next release intended to bump the major version? If not, any apps relying on `buildMessage` will be broken.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.