adopted-ember-addons / adopted-ember-addons/ember-changeset-validations

`buildMessage` function is backwards incompatible

Abierto
#141 2 comentarios 2 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
215
Forks
98
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

## Version

Latest Master starting at #126

## Test Case

## Steps to reproduce

## Expected Behavior

From the Docs and existing behavior the `buildMessage` function should have a signature like this:
`buildMessage(key, type, value, context = {})`.

## Actual Behavior

On [this line](https://github.com/DockYard/ember-changeset-validations/blob/master/addon/utils/validation-errors.js#L17) the signature made a backwards incompatible change and now looks like this: `buildMessage(key, result)`.

Is the next release intended to bump the major version? If not, any apps relying on `buildMessage` will be broken.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.