adobe / adobe/aio-cli-plugin-runtime

enhance action create with env variables

未关闭
#116 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement help wanted
主要语言
JavaScript
星标
21
派生
33
PR 合并指标
30 天内没有已合并 PR

描述

**Describe the bug**
This was missed in the recently merged PR #103. The `-P` flag is overloaded to mean read params from file and read env from file. This is a copy/paste bug, the intent was to use `-E`.

https://github.com/adobe/aio-cli-plugin-runtime/pull/103/files#diff-6d51d7a8679a906a9bfdaf1a8b017006R207

Thanks to @purplecabbage for pointing this out. We were both surprised oclif didn't barf at this.

As an enhancement, Jesse also suggested supporting reading the value of an env var from the shell environemnt, so that you can do `... action create myAction -e FOO` which is syntactic sugar for `... action create myAction -e FOO $FOO`. I think this is neat/convenient (perhaps to be considered separately as an enhancement).

贡献指南

打开贡献指南

调研方向

检查 PR #103 中链接位置的 action create 选项处理,重点关注具有重载含义的 -P 标志和预期的 -E 标志。确认现有的参数文件行为,然后确定是否包含 shell 环境查找,还是将其单独处理;完成意味着这些标志具有不同的行为,并且所请求的命令用法已由测试覆盖。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
cli
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。