adobe / adobe/aio-cli-plugin-runtime

enhance action create with env variables

Open
#116 2 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
JavaScript
Stars
21
Forks
33
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
This was missed in the recently merged PR #103. The `-P` flag is overloaded to mean read params from file and read env from file. This is a copy/paste bug, the intent was to use `-E`.

https://github.com/adobe/aio-cli-plugin-runtime/pull/103/files#diff-6d51d7a8679a906a9bfdaf1a8b017006R207

Thanks to @purplecabbage for pointing this out. We were both surprised oclif didn't barf at this.

As an enhancement, Jesse also suggested supporting reading the value of an env var from the shell environemnt, so that you can do `... action create myAction -e FOO` which is syntactic sugar for `... action create myAction -e FOO $FOO`. I think this is neat/convenient (perhaps to be considered separately as an enhancement).

Contributor guide

Open the contributing guide

Research direction

Review the action create option handling at the location linked in PR #103, focusing on the overloaded -P flag and the intended -E flag. Confirm the existing parameter-file behavior, then determine whether shell environment lookup is included or treated separately; done means the flags have distinct behavior and the requested command usage is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.