PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add the ability to have a specific required corrupted implicit added to the trade search for the Timeless Jewel finder

Open
#9,804 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

As far as I can tell, currently the only way to search for timeless jewels that also have a specific corrupted implicit (for example: "corrupted blood cannot be inflicted on you") is to manually add it into every trade URL search via the "AND" stat group. For very common jewel seeds with hundreds or thousands of possible seeds it's especially bad.

I know this is a somewhat niche feature and only really useful for min-maxing, but I was trying to specifically find a glorious vanity socketed in the mind over matter socket with one specific node (lightning damage leeched as life) replacing the "arcanist's dominion" node while also having the immune to corrupted blood implicit. There's thousands of seeds with that specific node but very few that also have the corrupted blood implicit.

Describe the solution you'd like

It would be very nice to have an option in the Timeless Jewel finder to add in a required corrupted implicit that gets added into the trade search URL as well as the jewel seeds.

Even going through 20 no result searches would be much better than needing to manually add in the corrupted implicit to every search (and it having no results anyway).

Describe alternatives you've considered

As far as I know, the only way to currently achieve it is by manually adding the implicit into every jewel's trade search with the "AND" stat group.

I found a couple listings after going through like 20, but it took a long time adding it in manually every time, and finding the cheapest listing would take forever

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Timeless Jewel finder and the code that builds its trade search URLs. Trace how jewel seeds and existing AND stat groups are selected, then add the requested required corrupted implicit so it is included in both the seed search and generated trade URLs. Done means the option can be selected and produces searches containing that implicit.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
search, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.