PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Persistence anoint flat reduction does not impact trauma self-hit calculation

Open
#9,693 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

Persistence says: -10 Physical Damage taken from Hits; -1 Physical Damage taken from Hits per Level

Damage taken per trauma hits so I believe persistence should at lvl100 give flat reduction of 110 physical applied after mitigation to self damage. I have to admit I didn't test that in-game though.

Credits to Dan on Discord for pointing that out.

What is the value from the calculation in Path of Building?

Hovering Self-hit line in Skill type specific stats panel in Calcs tab shows no difference with persistence anointed or not.

How to reproduce the issue
  1. Link any skill that is supportable with trauma.
  2. Set character level to 100.
  3. Equip amulet with persistence anoint.
  4. Open calcs.
PoB for PoE1 build code
Without anoint: https://pobb.in/5TQyb567HhVk
With anoint: https://pobb.in/Wch7OYY-8iuj
Screenshots

Without anoint:

Image

With anoint:

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the two linked PoE1 build codes and compare the Self-hit line in the Calcs tab with and without the Persistence anoint. Follow the calculation path for Trauma self-hit damage and Persistence's flat physical damage reduction. Done means the Calcs result reflects the level-scaled reduction when Persistence is anointed.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.