PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add approximation for "Celestial Mathmatics" Average Hit + Add option for Ward uptime in Config

Open
#9,680 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

As of now, the only way to sort of calculate "celestial mathmatics" damage is by using "Gain added Chaos Damage equal to 25% of your Ward", then allocating "Cryogenesis"

This is very inconvenient if you want to compare passive trees that do not use "Cryogenesis"

Describe the solution you'd like
  1. Add a Slider in config "Is your Ward unbroken?"
  2. Set options in Slider to [ No / Yes / Bypass Ward Restore]
  3. for "Yes", check how many attacks happen per second during ward restoration time, then give added damage equal to:

n*(1/x)
n = 25% of your Ward
x = amount of attacks during ward restoration cooldown, rounded down

  1. Apply "Celestial mathmatics" similar to Nightgrip for "Bypass Ward Restore"

(5.* optional: Make "No" disable ward in EHP calculations)

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points, so first locate the config controls and damage-calculation code for Ward and Celestial Mathematics. Done means the requested Ward states produce the specified approximation, the optional EHP behavior is resolved, and the behavior is covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.