PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Penance Brand of Dissipation calculation varitation
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
Penance brand of dissipation currently has two calculation modes neither of which accurately convey its real damage very well (further explanation below).
Describe the solution you'd like
There should be another (?) mode called something like "average damage per cast" that averages the damage ticks the brand does over the full duration
Describe alternatives you've considered
No response
Additional context
Energy pulse where you can manually input the amount of stacks it is on
Max pulse per brand where it calculates the maximum stacks the brand can acquire given the tick rate and the duration and displays the damage that maximum pulse does; this mode doesn't consider the ramp it takes and thus heavily distorts the value cast speed and duration have: duration is considered very good until 20 activations per brand and useless thereafter for example.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing Penance Brand of Dissipation calculation modes and reviewing how their damage ticks, stack counts, cast rate, and duration are modeled. Done should include a clearly defined additional calculation mode that averages damage over the full duration, while addressing the requested manual-stack and maximum-pulse behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100