PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

The Consuming Dark unique poison chance ignores Perfect Agony keystone's "Non-Critical Strikes cannot inflict Ailments"

Open
#7,873 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

Not tested in-game as v3.25 has nott been released yet

What is the value from the calculation in Path of Building?

In Path of Building when I equip The Consuming Dark unique dagger while having allocated the keystone "Perfect Agony" and using a skill that deals chaos damage (either directly or through damage conversion), Path of Building calculates the incorrect poison chance on non-crit to be 60% (100% using two The Consuming Dark) when it should instead be 0% since Perfect Agony's "Non-Critical Strikes cannot inflict Ailments" should apply to poison.

How to reproduce the issue
  1. Select "Explosive Trap of Shrapnel" as the main skill. (Also tested with Fireball and Soulrend)
  2. Equip "The Consuming Dark" as Weapon 1.
  3. Allocate "Perfect Agony" keystone in the passive skill tree.
  4. Check "Chance to Poison" -> "Chance on Non-Crit" on the Calculations tab to see the incorrect value.
Character build code
https://pobb.in/v3tBNksQxHgz
Screenshots

image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the supplied character build code and reproduce the result in the Calculations tab using The Consuming Dark, Perfect Agony, and a chaos-damaging skill. Trace the calculation that reports Chance on Non-Crit for poison; done means non-critical poison chance is 0% with Perfect Agony while the expected unique-item behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.