PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Multiple incorrect errors when searching for ring to replace ring with life reservation efficiency

オープン
#7,641 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

bug
主要言語
Lua
スター
5.4k
フォーク
2.4k
平均マージ
1日 12時間
マージ済み PR(30日)
26

説明

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
How is Path of Building expected to behave?

Minimum behavior to solve the issue:
When I click "Find best", PoB displays an error message that makes sense. For example "Cannot generate weighted search because one or more modifiers on the item being replaced increases your EHP by infinity."

Beyond the bug into feature request territory:
I want PoB to generate a link that includes life reservation efficiency as a required mod, and the remaining mods by weight as it currently does. This is what I do to work around the issue. Happy to split this into a separate feature request if the team likes the idea and wants me to split it.

How does Path of Building behave?

When I click "Find best", PoB generates an error message.

How to reproduce the issue

I created a minimal build for this issue and referenced it in the steps below. If I need to provide steps to repro from scratch, please let me know.

  1. Load the character build code.
  2. On the Items tab, click "Trade for these items."
  3. Adjust search weights such that Effective Hit Pool is at 1.00 and all other weights are zero.
  4. On the Ring 1 slot, click "Find Best".

Observe error:
Could not generate search, change active skill or enable FullDPS on some skills.

  1. On the Skills tab, enable the "Include in Full DPS" option for Smite.
  2. Once again attempt to generate an item for the Ring 1 slot.

Observe error
Could not generate search, found no mods to search for.

I believe the problem is that without life reservation efficiency on the ring, the character would have an EHP value of -inf. When PoB attempts to find a replacement, it probably fails because the weighted value of life reservation efficiency is infinitely higher than every other modifier. This seems like something PoB could detect and, at the very least, display a more appropriate error message.

Related to #6119. The main difference is that in #6119, it is not possible to improve on infinite EHP. The character in this issue has a finite EHP, and it is possible (albeit more difficult than usual) to improve.

Character build code
https://pobb.in/TEmwxlYacqpX
Screenshots

image

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

提供されたPoBビルドを読み込み、Items > Trade からこれらのアイテムに対して > Find Best を実行して問題を再現します。まず Effective Hit Pool のみを重み付けし、次に Full DPS に Smite を含めます。2つのエラーパスを調査し、関連する issue #6119 に記載された動作と比較します。完了条件は、失敗が正確に報告され、必要に応じてライフ予約効率の機能リクエストが別途扱われることです。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
lua
領域
tooling
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。