PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Multiple incorrect errors when searching for ring to replace ring with life reservation efficiency

Ouverte
#7,641 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

bug
Langage dominant
Lua
Étoiles
5.4k
Forks
2.4k
Merge moyen
1 j 12 h
PR mergées (30 j)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
How is Path of Building expected to behave?

Minimum behavior to solve the issue:
When I click "Find best", PoB displays an error message that makes sense. For example "Cannot generate weighted search because one or more modifiers on the item being replaced increases your EHP by infinity."

Beyond the bug into feature request territory:
I want PoB to generate a link that includes life reservation efficiency as a required mod, and the remaining mods by weight as it currently does. This is what I do to work around the issue. Happy to split this into a separate feature request if the team likes the idea and wants me to split it.

How does Path of Building behave?

When I click "Find best", PoB generates an error message.

How to reproduce the issue

I created a minimal build for this issue and referenced it in the steps below. If I need to provide steps to repro from scratch, please let me know.

  1. Load the character build code.
  2. On the Items tab, click "Trade for these items."
  3. Adjust search weights such that Effective Hit Pool is at 1.00 and all other weights are zero.
  4. On the Ring 1 slot, click "Find Best".

Observe error:
Could not generate search, change active skill or enable FullDPS on some skills.

  1. On the Skills tab, enable the "Include in Full DPS" option for Smite.
  2. Once again attempt to generate an item for the Ring 1 slot.

Observe error
Could not generate search, found no mods to search for.

I believe the problem is that without life reservation efficiency on the ring, the character would have an EHP value of -inf. When PoB attempts to find a replacement, it probably fails because the weighted value of life reservation efficiency is infinitely higher than every other modifier. This seems like something PoB could detect and, at the very least, display a more appropriate error message.

Related to #6119. The main difference is that in #6119, it is not possible to improve on infinite EHP. The character in this issue has a finite EHP, and it is possible (albeit more difficult than usual) to improve.

Character build code
https://pobb.in/TEmwxlYacqpX
Screenshots

image

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Chargez le build PoB fourni, puis reproduisez le problème via Items > Trade pour ces objets > Find Best, d’abord en pondérant uniquement Effective Hit Pool, puis en incluant Smite dans Full DPS. Examinez les deux chemins d’erreur et comparez-les au comportement décrit dans l’issue associée #6119 ; le travail est considéré comme terminé lorsque l’échec est signalé avec précision et que la demande de fonctionnalité concernant l’efficacité de réservation de vie est traitée séparément si nécessaire.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
lua
Domaine
tooling
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.