PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Multiple incorrect errors when searching for ring to replace ring with life reservation efficiency
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
How is Path of Building expected to behave?
Minimum behavior to solve the issue:
When I click "Find best", PoB displays an error message that makes sense. For example "Cannot generate weighted search because one or more modifiers on the item being replaced increases your EHP by infinity."
Beyond the bug into feature request territory:
I want PoB to generate a link that includes life reservation efficiency as a required mod, and the remaining mods by weight as it currently does. This is what I do to work around the issue. Happy to split this into a separate feature request if the team likes the idea and wants me to split it.
How does Path of Building behave?
When I click "Find best", PoB generates an error message.
How to reproduce the issue
I created a minimal build for this issue and referenced it in the steps below. If I need to provide steps to repro from scratch, please let me know.
- Load the character build code.
- On the Items tab, click "Trade for these items."
- Adjust search weights such that Effective Hit Pool is at 1.00 and all other weights are zero.
- On the Ring 1 slot, click "Find Best".
Observe error:
Could not generate search, change active skill or enable FullDPS on some skills.
- On the Skills tab, enable the "Include in Full DPS" option for Smite.
- Once again attempt to generate an item for the Ring 1 slot.
Observe error
Could not generate search, found no mods to search for.
I believe the problem is that without life reservation efficiency on the ring, the character would have an EHP value of -inf. When PoB attempts to find a replacement, it probably fails because the weighted value of life reservation efficiency is infinitely higher than every other modifier. This seems like something PoB could detect and, at the very least, display a more appropriate error message.
Related to #6119. The main difference is that in #6119, it is not possible to improve on infinite EHP. The character in this issue has a finite EHP, and it is possible (albeit more difficult than usual) to improve.
Character build code
https://pobb.in/TEmwxlYacqpX
Screenshots
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Carga la build de PoB proporcionada y reproduce el problema mediante Items > Trade para estos objetos > Find Best, primero ponderando únicamente Effective Hit Pool y después incluyendo Smite en Full DPS. Investiga las dos rutas de error y compáralas con el comportamiento descrito en el issue relacionado #6119; se considera terminado cuando el fallo se informa con precisión y la solicitud de funcionalidad sobre la eficiencia de reserva de vida se trata por separado si es necesario.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- tooling
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100