PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Effective HP pool bugged

Aperta
#6,871 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

bug: calculation
Lingua principale
Lua
Stelle
5.4k
Fork
2.4k
Merge medio
1g 12h
PR unite (30g)
26

Descrizione

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

I used to have a value of around 64k effective HP on my build, but after i went into the config and checked uber shaper slam with 100 %roll and 100% crit then back to no boss selected and back to guardian/pinnacle boss toggled my Effective HP pool was 451k which is obviously not true
image
Sadly don't have a ss from before the change happened, but have been able to reproduce the bug (esp if you repeat aforementioned steps, the number will keep increasing)

After writing this entire report and testing it, i cant seem to replicate it on the given file, so i'll attach a second build to showcase it

What is the value from the calculation in Path of Building?

I believe the Effective HP pool isn't properly "cleared" off stats when you change, and thus adding on top of itself each time you "swap" between steps, the actual formula I do not know

How to reproduce the issue

Go into config
Set enemy stats from guardian pinnacle to Ubers
set skill preset to for example shaper slam
change the skill range % from 70 to 100
change crit chance from 0 to 100
set skill preset back to none
set boss back to guardian and keep swapping for number increase change to multiply

Character build code
this happens in any build, but its currently broken in this one

https://pobb.in/qPPnuN7Q-V_F
Screenshots

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/42869616/98939bdc-5f68-482a-8f8b-58194948cf43

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/42869616/905d8c29-d3a9-4e65-91e0-fce9d34ea64b

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia caricando la build collegata e riproducendo la sequenza di configurazione: passa dai boss Guardian/Pinnacle ai boss Uber e viceversa, modifica la portata e la probabilità di critico di Shaper Slam, quindi reimposta le selezioni. Traccia il calcolo degli HP effettivi man mano che queste impostazioni cambiano e verifica che gli scambi ripetuti non aumentino più erroneamente il pool visualizzato.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
lua
Ambito
backend
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
30/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.