PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Effective HP pool bugged

Abierto
#6,871 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug: calculation
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

I used to have a value of around 64k effective HP on my build, but after i went into the config and checked uber shaper slam with 100 %roll and 100% crit then back to no boss selected and back to guardian/pinnacle boss toggled my Effective HP pool was 451k which is obviously not true
image
Sadly don't have a ss from before the change happened, but have been able to reproduce the bug (esp if you repeat aforementioned steps, the number will keep increasing)

After writing this entire report and testing it, i cant seem to replicate it on the given file, so i'll attach a second build to showcase it

What is the value from the calculation in Path of Building?

I believe the Effective HP pool isn't properly "cleared" off stats when you change, and thus adding on top of itself each time you "swap" between steps, the actual formula I do not know

How to reproduce the issue

Go into config
Set enemy stats from guardian pinnacle to Ubers
set skill preset to for example shaper slam
change the skill range % from 70 to 100
change crit chance from 0 to 100
set skill preset back to none
set boss back to guardian and keep swapping for number increase change to multiply

Character build code
this happens in any build, but its currently broken in this one

https://pobb.in/qPPnuN7Q-V_F
Screenshots

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/42869616/98939bdc-5f68-482a-8f8b-58194948cf43

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/42869616/905d8c29-d3a9-4e65-91e0-fce9d34ea64b

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza cargando la build enlazada y reproduciendo la secuencia de configuración: cambia entre jefes Guardian/Pinnacle y Uber, modifica el alcance y la probabilidad de crítico de Shaper Slam y, después, restablece las selecciones. Sigue el cálculo de la vida efectiva a medida que cambian esos ajustes y verifica que los intercambios repetidos ya no aumenten incorrectamente el pool mostrado.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
backend
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
30/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.