PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Effective HP pool bugged

Open
#6,871 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

I used to have a value of around 64k effective HP on my build, but after i went into the config and checked uber shaper slam with 100 %roll and 100% crit then back to no boss selected and back to guardian/pinnacle boss toggled my Effective HP pool was 451k which is obviously not true
image
Sadly don't have a ss from before the change happened, but have been able to reproduce the bug (esp if you repeat aforementioned steps, the number will keep increasing)

After writing this entire report and testing it, i cant seem to replicate it on the given file, so i'll attach a second build to showcase it

What is the value from the calculation in Path of Building?

I believe the Effective HP pool isn't properly "cleared" off stats when you change, and thus adding on top of itself each time you "swap" between steps, the actual formula I do not know

How to reproduce the issue

Go into config
Set enemy stats from guardian pinnacle to Ubers
set skill preset to for example shaper slam
change the skill range % from 70 to 100
change crit chance from 0 to 100
set skill preset back to none
set boss back to guardian and keep swapping for number increase change to multiply

Character build code
this happens in any build, but its currently broken in this one

https://pobb.in/qPPnuN7Q-V_F
Screenshots

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/42869616/98939bdc-5f68-482a-8f8b-58194948cf43

https://github.com/PathOfBuildingCommunity/PathOfBuilding/assets/42869616/905d8c29-d3a9-4e65-91e0-fce9d34ea64b

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by loading the linked build and reproducing the configuration sequence: switch between Guardian/Pinnacle and Uber bosses, change the Shaper Slam range and crit chance, then reset the selections. Trace the effective HP calculation as those settings change and verify that repeated swaps no longer increase the displayed pool incorrectly.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.