PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Incorrect Ignite Eff. DoT Multi calculation

オープン
#6,272 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

bug: calculation
主要言語
Lua
スター
5.4k
フォーク
2.4k
平均マージ
1日 12時間
マージ済み PR(30日)
26

説明

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

Not entirely sure how it's supposed to work among the possible cases, but the numbers in PoB look absurd to me.

What is the value from the calculation in Path of Building?

See in PoB with the example.
The "portion of instances created by non-crits" and "portion of instances created by crits" number for Ignite's "Eff. DoT Multi" have what I believe to be incorrect numbers.
I'd assume a crit would always result in the bonus 50% dot multi regardless of the normal ignite chance. Yet even with 100% base ignite chance, the portion created by non-crits has a 0.4726 multiplier and the portion created by crits has 0.5274, when the skill has 20% crit chance. (See screenshot below.)

Or is it normal that my ignite dps literally goes down with higher ignite chance?
I assume PoB is doing some complex probability calc in the background and that's why, but it's extremely unintuitive and unexplained. My intuition would be to give the ignite dps for when the enemy is ignited when the "is the enemy ignited" is checked in config, not a probabilistic dps that includes the times where the mob is not ignited. Or at least these two numbers could be separated then, and an additional info on avg. percentage uptime of ignite could be added next to those two. As these shenanigans are the only thing I could think of that would make ignite dps become lower with higher ignite chance.

(PoB version 2.30.1)

How to reproduce the issue
  1. Import the example PoB - https://pobb.in/DL96wl1VqAl2
  2. Switch between the custom made gloves which only give ignite chance
  3. See the changes it results on the "Calcs" tab in the "Ignite" panel in the "Eff. DoT Multi" line.
  4. In the tooltip of the "Eff. DoT Multi" line the "portion of instances created by non-crits" and "portion of instances created by crits" numbers look absurd.
Character build code
https://pobb.in/DL96wl1VqAl2
Screenshots

100 base ignite chance with 20 crit

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

サンプルの PoB をインポートし、Calcs タブの Ignite パネルを調査します。特に Eff. DoT Multi のツールチップを確認し、Ignite の確率が変わるカスタムグローブを切り替えます。非クリティカル部分とクリティカル部分、および結果として得られる Ignite DPS を比較します。完了条件は、意図された確率計算を明らかにし、表示値を修正するか、期待される動作を文書化することです。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
lua
領域
backend
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
説明が足りない
初心者へのやさしさ
25/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。