PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Incorrect Ignite Eff. DoT Multi calculation

Aperta
#6,272 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

bug: calculation
Lingua principale
Lua
Stelle
5.4k
Fork
2.4k
Merge medio
1g 12h
PR unite (30g)
26

Descrizione

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

Not entirely sure how it's supposed to work among the possible cases, but the numbers in PoB look absurd to me.

What is the value from the calculation in Path of Building?

See in PoB with the example.
The "portion of instances created by non-crits" and "portion of instances created by crits" number for Ignite's "Eff. DoT Multi" have what I believe to be incorrect numbers.
I'd assume a crit would always result in the bonus 50% dot multi regardless of the normal ignite chance. Yet even with 100% base ignite chance, the portion created by non-crits has a 0.4726 multiplier and the portion created by crits has 0.5274, when the skill has 20% crit chance. (See screenshot below.)

Or is it normal that my ignite dps literally goes down with higher ignite chance?
I assume PoB is doing some complex probability calc in the background and that's why, but it's extremely unintuitive and unexplained. My intuition would be to give the ignite dps for when the enemy is ignited when the "is the enemy ignited" is checked in config, not a probabilistic dps that includes the times where the mob is not ignited. Or at least these two numbers could be separated then, and an additional info on avg. percentage uptime of ignite could be added next to those two. As these shenanigans are the only thing I could think of that would make ignite dps become lower with higher ignite chance.

(PoB version 2.30.1)

How to reproduce the issue
  1. Import the example PoB - https://pobb.in/DL96wl1VqAl2
  2. Switch between the custom made gloves which only give ignite chance
  3. See the changes it results on the "Calcs" tab in the "Ignite" panel in the "Eff. DoT Multi" line.
  4. In the tooltip of the "Eff. DoT Multi" line the "portion of instances created by non-crits" and "portion of instances created by crits" numbers look absurd.
Character build code
https://pobb.in/DL96wl1VqAl2
Screenshots

100 base ignite chance with 20 crit

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Importa il PoB di esempio e ispeziona il pannello Ignite della scheda Calcs, in particolare il tooltip di Eff. DoT Multi, mentre passi da un paio di guanti personalizzati all’altro che modificano la probabilità di Ignite. Confronta le parti non-crit e crit e l’Ignite DPS risultante; per completare il lavoro è necessario stabilire il calcolo della probabilità previsto e correggere i valori visualizzati oppure documentare il comportamento atteso.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
lua
Ambito
backend
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
25/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.