PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Incorrect Ignite Eff. DoT Multi calculation
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
Not entirely sure how it's supposed to work among the possible cases, but the numbers in PoB look absurd to me.
What is the value from the calculation in Path of Building?
See in PoB with the example.
The "portion of instances created by non-crits" and "portion of instances created by crits" number for Ignite's "Eff. DoT Multi" have what I believe to be incorrect numbers.
I'd assume a crit would always result in the bonus 50% dot multi regardless of the normal ignite chance. Yet even with 100% base ignite chance, the portion created by non-crits has a 0.4726 multiplier and the portion created by crits has 0.5274, when the skill has 20% crit chance. (See screenshot below.)
Or is it normal that my ignite dps literally goes down with higher ignite chance?
I assume PoB is doing some complex probability calc in the background and that's why, but it's extremely unintuitive and unexplained. My intuition would be to give the ignite dps for when the enemy is ignited when the "is the enemy ignited" is checked in config, not a probabilistic dps that includes the times where the mob is not ignited. Or at least these two numbers could be separated then, and an additional info on avg. percentage uptime of ignite could be added next to those two. As these shenanigans are the only thing I could think of that would make ignite dps become lower with higher ignite chance.
(PoB version 2.30.1)
How to reproduce the issue
- Import the example PoB - https://pobb.in/DL96wl1VqAl2
- Switch between the custom made gloves which only give ignite chance
- See the changes it results on the "Calcs" tab in the "Ignite" panel in the "Eff. DoT Multi" line.
- In the tooltip of the "Eff. DoT Multi" line the "portion of instances created by non-crits" and "portion of instances created by crits" numbers look absurd.
Character build code
https://pobb.in/DL96wl1VqAl2
Screenshots
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Importiere das Beispiel-PoB und untersuche das Ignite-Panel des Calcs-Tabs, insbesondere den Tooltip von Eff. DoT Multi, während du zwischen den benutzerdefinierten Handschuhen wechselst, die die Ignite-Chance ändern. Vergleiche die Nicht-Krit- und Krit-Anteile sowie den resultierenden Ignite-DPS; für den Abschluss muss die vorgesehene Wahrscheinlichkeitsberechnung ermittelt und die angezeigten Werte korrigiert oder das erwartete Verhalten dokumentiert werden.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- backend
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 25/100