PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Hollow Palm's added damage not applying to Volcanic Fissure Projectiles

Open
#5,412 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation ingame?

The wording from Hollow Palm Technique is that it adds 14-20 Attack Physical Damage to Melee Skills per 10 Dexterity while you are Unencumbered.

In game, it provides damage for both the AoE of the slam, and for the projectiles, as the projectiles are still caused by a "melee skill"

What is the value from the calculation in Path of Building?

The wording from Hollow Palm Technique is that it adds 14-20 Attack Physical Damage to Melee Skills per 10 Dexterity while you are Unencumbered.

In game, it provides damage for only the AoE of the slam, but not for the projectiles. PoB is not considering the projectiles to be part of the "melee skill"

How to reproduce the issue

Grant Hollow Palm Technique via Replica Perfect Form or via One With Nothing

Add Volcanic Fissure to the skill set, and select Magma Balls

Character build code
https://pobb.in/esh1iYLHqwqh
Screenshots

https://user-images.githubusercontent.com/14267662/208460769-41152bf2-6d98-48c9-98f2-775aea1d3a7b.mp4

As you can see in the video, without gloves equipped in order to meet the Unencumbered modifier, the projectiles easily kill the monsters. With the gloves equipped, and thus not being Unencumbered, it does not do much. So the added damage of Hollow Palm is intended to work on the projectiles, as it does it in game

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the calculation with Hollow Palm Technique from Replica Perfect Form or One With Nothing, then add Volcanic Fissure and select Magma Balls using the linked build code. Compare the projectile damage with and without gloves equipped; done means Hollow Palm's added attack physical damage is applied to the projectiles as it is to the slam's area damage.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.